Skip to content

Conversation

mcremon-meta
Copy link
Contributor

Summary: As a bonus, it allows us to fully remove the fallback, since all cases for fp32 are optimized (unless a tensor is more than 16 dims, which is probably ok for a few years)

Differential Revision: D81172654

Copy link

pytorch-bot bot commented Aug 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13750

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit 9bd2a33 with merge base 0d0769a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81172654

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81172654

mcremon-meta added a commit that referenced this pull request Aug 28, 2025
Summary:
Pull Request resolved: #13750

As a bonus, it allows us to fully remove the fallback, since all cases for fp32 are optimized (unless a tensor is more than 16 dims, which is probably ok for a few years)

Differential Revision: D81172654
Summary:
Pull Request resolved: #13750

As a bonus, it allows us to fully remove the fallback, since all cases for fp32 are optimized (unless a tensor is more than 16 dims, which is probably ok for a few years)

Reviewed By: JakeStevens

Differential Revision: D81172654
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81172654

@facebook-github-bot facebook-github-bot merged commit 579b91e into main Sep 2, 2025
111 of 115 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D81172654 branch September 2, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants