Skip to content

Conversation

MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Aug 28, 2025

Summary

This PR ensures that input models are always in evaluation mode. Additionally, a deprecated export call was replaced by an up-to-date one.

Test plan

Correct function is tested by most of the existing tests.

cc @robert-kalmar @roman-janik-nxp @StrycekSimon @jirioc

Copy link

pytorch-bot bot commented Aug 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13756

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit d901c99 with merge base afb09d0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@MartinPavella
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Aug 28, 2025
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-500-disable-training-mode-for-executorch-models branch from 868d817 to ccb02c6 Compare August 28, 2025 12:52
@robert-kalmar robert-kalmar self-requested a review August 28, 2025 13:33
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-500-disable-training-mode-for-executorch-models branch from ccb02c6 to e564c4b Compare September 1, 2025 06:21
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-500-disable-training-mode-for-executorch-models branch from e564c4b to e905dcd Compare September 1, 2025 06:29
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-500-disable-training-mode-for-executorch-models branch from e905dcd to d901c99 Compare September 1, 2025 13:59
@robert-kalmar robert-kalmar merged commit 71a7806 into pytorch:main Sep 2, 2025
112 of 113 checks passed
@robert-kalmar robert-kalmar deleted the upstream/main-nxp/EIEX-500-disable-training-mode-for-executorch-models branch September 2, 2025 09:14
@shoumikhin
Copy link
Contributor

@MartinPavella please check if this CI failure is related to your change
https://github.com/pytorch/executorch/actions/runs/17398933240/job/49387315586

@robert-kalmar
Copy link
Collaborator

@MartinPavella please check if this CI failure is related to your change https://github.com/pytorch/executorch/actions/runs/17398933240/job/49387315586

It is, Martin already works on the follow up fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants