-
Notifications
You must be signed in to change notification settings - Fork 685
NXP backend: Fix incorrect linear
test.
#13760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP backend: Fix incorrect linear
test.
#13760
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13760
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit fa9ebc9 with merge base 1520f9f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: nxp" "release notes: nxp" |
@JakeStevens thank you for pointing out the incorrect test. However, I cannot replicate your issue:
The test case passes without issues for me. |
@JakeStevens , @MartinPavella , what neutron converter revision you used for testing? The tests here uses still the NeutronConverter_SDK_25.03. |
input_shape = (10, 32) | ||
edge_program = to_edge_program( | ||
LinearModule(bias=True), input_shape | ||
LinearModule(bias=False), input_shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious how did we not test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must have missed it in the rapid development during the early stages.
I have updated the tests again, to make sure the bias is (or is not) present.
I use |
9aa608c
to
46442a5
Compare
46442a5
to
fa9ebc9
Compare
Summary
This PR fixes an incorrect
linear
test without a bias.Test plan
Unit test provided.
cc @robert-kalmar @jirioc @JakeStevens