Skip to content

Conversation

MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Aug 28, 2025

Summary

This PR fixes an incorrect linear test without a bias.

Test plan

Unit test provided.

cc @robert-kalmar @jirioc @JakeStevens

Copy link

pytorch-bot bot commented Aug 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13760

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit fa9ebc9 with merge base 1520f9f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@MartinPavella
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Aug 28, 2025
@MartinPavella
Copy link
Collaborator Author

@JakeStevens thank you for pointing out the incorrect test. However, I cannot replicate your issue:

I believe bias=False causes a crash, or at least does for me in the converter

The test case passes without issues for me.

@robert-kalmar
Copy link
Collaborator

@JakeStevens thank you for pointing out the incorrect test. However, I cannot replicate your issue:

I believe bias=False causes a crash, or at least does for me in the converter

The test case passes without issues for me.

@JakeStevens , @MartinPavella , what neutron converter revision you used for testing? The tests here uses still the NeutronConverter_SDK_25.03.
Jake the crash in your case was with 25.06?

input_shape = (10, 32)
edge_program = to_edge_program(
LinearModule(bias=True), input_shape
LinearModule(bias=False), input_shape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious how did we not test this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have missed it in the rapid development during the early stages.
I have updated the tests again, to make sure the bias is (or is not) present.

@MartinPavella
Copy link
Collaborator Author

@JakeStevens thank you for pointing out the incorrect test. However, I cannot replicate your issue:

I believe bias=False causes a crash, or at least does for me in the converter

The test case passes without issues for me.

@JakeStevens , @MartinPavella , what neutron converter revision you used for testing? The tests here uses still the NeutronConverter_SDK_25.03. Jake the crash in your case was with 25.06?

I use 25.03.

@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-513-no-bias-causes-a-crash-in-the-converter branch from 9aa608c to 46442a5 Compare September 1, 2025 07:27
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-513-no-bias-causes-a-crash-in-the-converter branch from 46442a5 to fa9ebc9 Compare September 1, 2025 07:28
@robert-kalmar robert-kalmar self-requested a review September 1, 2025 07:52
@robert-kalmar robert-kalmar merged commit 0bfbe44 into pytorch:main Sep 2, 2025
111 of 113 checks passed
@robert-kalmar robert-kalmar deleted the upstream/main-nxp/EIEX-513-no-bias-causes-a-crash-in-the-converter branch September 2, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants