Skip to content

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Aug 29, 2025

When building arm_executor_runner.cpp with the two macros ET_EVENT_TRACER_ENABLED and SEMIHOSTING set, compilation errors occur. This patch corrects the code to fix this problem.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

When building arm_executor_runner.cpp with the two macros
ET_EVENT_TRACER_ENABLED and SEMIHOSTING set, compilation errors occur.
This patch corrects the code to fix this problem.

Change-Id: I14eb0d797f885a08c78328f45297b07d1127b5e6
@martinlsm martinlsm requested a review from digantdesai as a code owner August 29, 2025 06:06
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13792

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 4 Unrelated Failures

As of commit 19cef0b with merge base 176800e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorch pytorch deleted a comment from pytorch-bot bot Aug 29, 2025
@pytorch pytorch deleted a comment from pytorch-bot bot Aug 29, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Aug 29, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@zingo
Copy link
Collaborator

zingo commented Sep 2, 2025

Build fails are unrelated

@zingo zingo merged commit 64db0c1 into pytorch:main Sep 2, 2025
240 of 247 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants