Revert exposed_as_util functionality and refactor stack utils #13822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13822
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 03e1aaf with merge base 874d3c1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
manuelcandales
added
the
release notes: none
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Aug 29, 2025
Summary: Pull Request resolved: pytorch#13822 Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
a94b639 to
232eee8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
swolchok
requested changes
Sep 2, 2025
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: pytorch#13822 Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
232eee8 to
4ebfc76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: pytorch#13822 Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
4ebfc76 to
72da750
Compare
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 3, 2025
…h#13822) Summary: This diff reverts the exposed_as_util functionality introduced in D79654142, and consequently, refactors the stack utils. Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
72da750 to
53167c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
manuelcandales
changed the title
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 3, 2025
…h#13822) Summary: This diff reverts the exposed_as_util functionality introduced in D79654142, and consequently, refactors the stack utils. Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
53167c9 to
903c7b7
Compare
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 3, 2025
…h#13822) Summary: This diff reverts the exposed_as_util functionality introduced in D79654142, and consequently, refactors the stack utils. Differential Revision: D81199586
manuelcandales
force-pushed
the
export-D81199586
branch
from
903c7b7 to
f38a91c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
…h#13822) Summary: This diff reverts the exposed_as_util functionality introduced in D79654142, and consequently, refactors the stack utils. Pull Request resolved: pytorch#13822 Differential Revision: D81199586
|
This pull request was exported from Phabricator. Differential Revision: D81199586 |
manuelcandales
force-pushed
the
export-D81199586
branch
from
f38a91c to
03e1aaf
Compare
swolchok
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the exposed_as_util functionality introduced in #13200, and consequently, refactors the stack utils.
Differential Revision: D81199586