Skip to content

Fix reduction over dim list for empty input #13833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Fix reduction over dim list for empty input #13833

merged 1 commit into from
Sep 4, 2025

Conversation

manuelcandales
Copy link
Contributor

Summary:
Allow empty input in MapReduceOverDimListPlan
Avoid integer division by zero in parallel_for_each_reduce_over_dim_list_output_index
Add empty input tests for ops: any, mean, sum & var

Differential Revision: D81383049

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13833

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 71e0873 with merge base f0368db (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81383049

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Sep 1, 2025
@manuelcandales @facebook-github-bot
Fix reduction over dim list for empty input (pytorch#13833)
b495ae3 
Summary:

Allow empty input in `MapReduceOverDimListPlan`
Avoid integer division by zero in `parallel_for_each_reduce_over_dim_list_output_index`
Add empty input tests for ops: any, mean, sum & var

Differential Revision: D81383049
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81383049

swolchok
swolchok requested changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@manuelcandales @facebook-github-bot
Fix reduction over dim list for empty input (pytorch#13833)
71e0873 
Summary:

Allow empty input in `MapReduceOverDimListPlan`
Avoid integer division by zero in `parallel_for_each_reduce_over_dim_list_output_index`
Add empty input tests for ops: any, mean, sum & var

Differential Revision: D81383049
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81383049

@facebook-github-bot facebook-github-bot merged commit 497f59c into pytorch:main Sep 4, 2025
112 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelcandales @facebook-github-bot @swolchok