Update backend-agnostic quantize_per_tensor to use scale_inv to match the quantize_per_tensor_out implementation #13846

DrJessop · 2025-09-01T21:26:12Z

Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation

Differential Revision: D81459313

pytorch-bot · 2025-09-01T21:26:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13846

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 6a4ee59 with merge base c5ff74c ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest-editable / macos / macos-job (gh)
backends/xnnpack/test/ops/test_rsqrt.py::TestRsqrt::test_fp16_rsqrt

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-setup-linux-gcc / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-09-01T21:26:22Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

github-actions · 2025-09-01T21:26:50Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

facebook-github-bot · 2025-09-03T00:54:37Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

facebook-github-bot · 2025-09-03T16:22:28Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: ethansfng Differential Revision: D81459313

facebook-github-bot · 2025-09-03T16:51:45Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

facebook-github-bot · 2025-09-04T00:14:05Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

facebook-github-bot · 2025-09-04T17:36:54Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

facebook-github-bot · 2025-09-04T18:34:46Z

This pull request was exported from Phabricator. Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Pull Request resolved: pytorch#13846 Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Differential Revision: D81459313

… the quantize_per_tensor_out implementation (pytorch#13846) Summary: Fixes an interface mismatch between the quantize_per_tensor_out implementation and the old quantize_per_tensor python implementation Reviewed By: hsharma35 Differential Revision: D81459313

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 1, 2025

facebook-github-bot added the fb-exported label Sep 1, 2025

DrJessop force-pushed the export-D81459313 branch from 90c1900 to 8cf01da Compare September 2, 2025 02:58

DrJessop force-pushed the export-D81459313 branch from 8cf01da to de7ccd9 Compare September 3, 2025 00:49

DrJessop force-pushed the export-D81459313 branch from de7ccd9 to 99adf67 Compare September 3, 2025 00:54

DrJessop force-pushed the export-D81459313 branch from 99adf67 to 84e2d92 Compare September 3, 2025 16:18

DrJessop force-pushed the export-D81459313 branch from 84e2d92 to ad84fe2 Compare September 3, 2025 16:22

ethansfng approved these changes Sep 3, 2025

View reviewed changes

DrJessop force-pushed the export-D81459313 branch from ad84fe2 to 40c119e Compare September 3, 2025 16:51

DrJessop force-pushed the export-D81459313 branch from 40c119e to 1da8029 Compare September 4, 2025 00:10

DrJessop force-pushed the export-D81459313 branch from 1da8029 to 0384242 Compare September 4, 2025 00:14

DrJessop force-pushed the export-D81459313 branch from 0384242 to 4d47fae Compare September 4, 2025 17:32

DrJessop force-pushed the export-D81459313 branch 2 times, most recently from 8a3075f to 98f03d6 Compare September 4, 2025 18:30

DrJessop force-pushed the export-D81459313 branch from 98f03d6 to 6a4ee59 Compare September 4, 2025 18:34

facebook-github-bot merged commit 30e7497 into pytorch:main Sep 4, 2025
113 of 118 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update backend-agnostic quantize_per_tensor to use scale_inv to match the quantize_per_tensor_out implementation #13846

Update backend-agnostic quantize_per_tensor to use scale_inv to match the quantize_per_tensor_out implementation #13846

Uh oh!

DrJessop commented Sep 1, 2025

Uh oh!

pytorch-bot bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Update backend-agnostic quantize_per_tensor to use scale_inv to match the quantize_per_tensor_out implementation #13846

Update backend-agnostic quantize_per_tensor to use scale_inv to match the quantize_per_tensor_out implementation #13846

Uh oh!

Conversation

DrJessop commented Sep 1, 2025

Uh oh!

pytorch-bot bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13846

❌ 2 New Failures, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 1, 2025 •

edited

Loading

This PR needs a `release notes:` label