Skip to content

NXP backend: Fix group convolution merge conflict. #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

NXP backend: Fix group convolution merge conflict. #13867

wants to merge 1 commit into from

Conversation

MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Sep 2, 2025 •
edited
Loading

Summary

This PR fixes a conflict introduced by merging group convolution support and calling .eval() on transformed models.

Test plan

Fixed unit tests are available in backends/nxp/tests/test_split_group_convolution.py

cc @robert-kalmar @roman-janik-nxp @StrycekSimon @jirioc

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13867

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Cancelled Job

As of commit 707febe with merge base 8ba92a9 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025
@MartinPavella
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Sep 2, 2025
@mergennachin
Copy link
Contributor

Run lintrunner -a please

@mergennachin mergennachin mentioned this pull request Sep 3, 2025
Merged
mergennachin added a commit that referenced this pull request Sep 3, 2025
@mergennachin @MartinPavella
NXP backend: Fix group convolution merge conflict (#13894)
19a54bc 
Updated version with lint fixes:
#13867

---------

Co-authored-by: Martin Pavella <martin.pavella@nxp.com>
@mergennachin
Copy link
Contributor

@MartinPavella

Just landed as part of #13894

We're trying to make our CI green this week, as we're approaching branch cut. Hence I went ahead landed the PR along the lint fixes, to avoid turnaround time.

@mergennachin
Copy link
Contributor

@MartinPavella

nvm, it didn't fix unfortunately,

see https://github.com/pytorch/executorch/actions/runs/17421840434/job/49461612346

@mergennachin
Copy link
Contributor

@JakeStevens

Looks like you're updating #13876

Is this related?

cc @shoumikhin

@MartinPavella
Copy link
Collaborator Author

MartinPavella commented Sep 3, 2025 •
edited
Loading

@MartinPavella

nvm, it didn't fix unfortunately,

see https://github.com/pytorch/executorch/actions/runs/17421840434/job/49461612346

This is actually another merge conflict caused by merging this PR and #13128. I'm working on the fix.
Edit: Fixed in #13900

@JakeStevens
Copy link
Contributor

@JakeStevens

Looks like you're updating #13876

Is this related?

cc @shoumikhin

no, my PR only affects internal targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinPavella @mergennachin @JakeStevens