Skip to content

Conversation

mergennachin
Copy link
Contributor

Summary:

Fixes two things:

  • There's a compilation error when building the tests due to missing header. Make sure it works via test_llama.sh
  • rpath isn't set correctly on MacOS

Test Plan:

cmake --preset llm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out

cmake --build cmake-out -j16 --target install --config Release

cmake -DCMAKE_INSTALL_PREFIX=cmake-out \
	-DBUILD_TESTING=OFF \
	-DCMAKE_BUILD_TYPE=Release \
	-Bcmake-out/examples/models/llama \
	examples/models/llama

cmake --build cmake-out/examples/models/llama -j16 --config Release

Copy link

pytorch-bot bot commented Sep 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13869

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 15 Pending, 2 Unrelated Failures

As of commit 853b6a2 with merge base e38c077 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025
@mergennachin mergennachin added the release notes: none Do not include this in the release notes label Sep 2, 2025
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D81497817.

@mergennachin mergennachin force-pushed the fix_build_test branch 3 times, most recently from 2e52d96 to b8282a6 Compare September 2, 2025 16:41
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D81497817.

Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I may have just merged a similar cmakelist change but feel free to override)

@mergennachin mergennachin force-pushed the fix_build_test branch 2 times, most recently from aadc911 to 9d1ba4f Compare September 2, 2025 18:04
Summary:

Fixes two things:

- There's a compilation error when building the tests due to missing header. Make sure it works via test_llama.sh
- rpath isn't set correctly on MacOS

Test Plan:

```
cmake --preset llm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out

cmake --build cmake-out -j16 --target install --config Release

cmake -DCMAKE_INSTALL_PREFIX=cmake-out \
	-DBUILD_TESTING=OFF \
	-DCMAKE_BUILD_TYPE=Release \
	-Bcmake-out/examples/models/llama \
	examples/models/llama

cmake --build cmake-out/examples/models/llama -j16 --config Release
```
@mergennachin mergennachin merged commit 842d946 into main Sep 2, 2025
370 of 374 checks passed
@mergennachin mergennachin deleted the fix_build_test branch September 2, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants