-
Notifications
You must be signed in to change notification settings - Fork 684
Fix llama runner on MacOS #13869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix llama runner on MacOS #13869
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13869
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 15 Pending, 2 Unrelated FailuresAs of commit 853b6a2 with merge base e38c077 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D81497817. |
2e52d96
to
b8282a6
Compare
@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D81497817. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I may have just merged a similar cmakelist change but feel free to override)
aadc911
to
9d1ba4f
Compare
Summary: Fixes two things: - There's a compilation error when building the tests due to missing header. Make sure it works via test_llama.sh - rpath isn't set correctly on MacOS Test Plan: ``` cmake --preset llm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out cmake --build cmake-out -j16 --target install --config Release cmake -DCMAKE_INSTALL_PREFIX=cmake-out \ -DBUILD_TESTING=OFF \ -DCMAKE_BUILD_TYPE=Release \ -Bcmake-out/examples/models/llama \ examples/models/llama cmake --build cmake-out/examples/models/llama -j16 --config Release ```
9d1ba4f
to
853b6a2
Compare
Summary:
Fixes two things:
Test Plan: