Del redundant-static-def in executorch/schema/extended_header.cpp +2 #13875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13875
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b6c10f0 with merge base a90e907 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81359733 |
JacobSzwejbka
requested changes
Sep 2, 2025
r-barnes
force-pushed
the
export-D81359733
branch
from
3be4987 to
e0a2fd7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81359733 |
r-barnes
added a commit
to r-barnes/executorch
that referenced
this pull request
Sep 8, 2025
…ytorch#13875) Summary: LLVM has a warning `-Wdeprecated-redundant-constexpr-static-def` which raises the warning: > warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated Since we are now on C++20, we can remove the out-of-line definition of constexpr static data members. This diff does so. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D81359733
…ytorch#13875) Summary: LLVM has a warning `-Wdeprecated-redundant-constexpr-static-def` which raises the warning: > warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated Since we are now on C++20, we can remove the out-of-line definition of constexpr static data members. This diff does so. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D81359733
r-barnes
force-pushed
the
export-D81359733
branch
from
e0a2fd7 to
b6c10f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81359733 |
JacobSzwejbka
approved these changes
Sep 8, 2025
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LLVM has a warning
-Wdeprecated-redundant-constexpr-static-defwhich raises the warning:Since we are now on C++20, we can remove the out-of-line definition of constexpr static data members. This diff does so.
Differential Revision: D81359733