Add program-data separation to pybindings #13886

lucylq · 2025-09-02T22:22:03Z

Summary: Add support for optional data path for pybindings.

Differential Revision: D76353209

facebook-github-bot · 2025-09-02T22:22:14Z

This pull request was exported from Phabricator. Differential Revision: D76353209

github-actions · 2025-09-02T22:22:44Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot · 2025-09-02T22:26:52Z

This pull request was exported from Phabricator. Differential Revision: D76353209

Summary: Pull Request resolved: pytorch#13886 Add support for optional data path for pybindings. Differential Revision: D76353209

pytorch-bot · 2025-09-02T22:27:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13886

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8eb077b with merge base fbda3a9 ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold

This comment was automatically generated by Dr. CI and updates every 15 minutes.

JacobSzwejbka · 2025-09-02T22:54:21Z

extension/pybindings/test/test_pybindings.py

+                tensor_data = bytes(exec_program._tensor_data.pop("_default_external_constant"))
+                ptd.write(tensor_data)
+
+            executorch_program = self.runtime._load_for_executorch(pte_file, ptd_file)


probably need to update the pyi

Thanks, updated!

Summary: Add support for optional data path for pybindings. Differential Revision: D76353209

facebook-github-bot · 2025-09-02T23:06:42Z

This pull request was exported from Phabricator. Differential Revision: D76353209

Summary: Add support for optional data path for pybindings. Differential Revision: D76353209

facebook-github-bot · 2025-09-02T23:43:04Z

This pull request was exported from Phabricator. Differential Revision: D76353209

mergennachin · 2025-09-03T14:00:24Z

extension/pybindings/test/test_pybindings.py

+                )
+                ptd.write(tensor_data)
+
+            executorch_program = self.runtime._load_for_executorch(pte_file, ptd_file)


It's fine to update the legacy API (methods that start with _) but we have modern pybindings APIs that we want users to use.

https://colab.research.google.com/drive/1qpxrXC3YdJQzly3mRg-4ayYiOjC6rue3?usp=sharing#scrollTo=Kp-MxVVHkirE

Don't we need to update runtime.load_program(pte, ptd) too?

Thanks Mergen, sorry for the late response. I think runtime.load_program is only intended to take a PTE file --> it understands and deserializes the PTE file format (not PTD). The C++ Program object doesn't hold a PTD file.

We can potentially support this in load_method, which takes a NamedDataMap (from PTD) as an optional argument. We'd need to add pybindings on extension/flat_tensor to load the PTD file for this.

Having it in Module may be OK at the moment, let me know what you think (I can add pybindings for extension/flat_tensor in a separate PR).

mergennachin

executorch/runtime/__init__.py

Lines 199 to 204 in cac1a71

    
           def load_program( 
        
               self, 
        
               data: Union[bytes, bytearray, BinaryIO, Path, str], 
        
               *, 
        
               verification: Verification = Verification.InternalConsistency, 
        
           ) -> Program:

Summary: Add support for optional data path for pybindings. Reviewed By: JacobSzwejbka Differential Revision: D76353209

facebook-github-bot · 2025-09-08T03:06:58Z

This pull request was exported from Phabricator. Differential Revision: D76353209

Summary: Pull Request resolved: pytorch#13886 Pull request resolved: pytorch#13886 Add support for optional data path for pybindings. Reviewed By: JacobSzwejbka Differential Revision: D76353209

facebook-github-bot · 2025-09-08T03:09:10Z

This pull request was exported from Phabricator. Differential Revision: D76353209

lucylq requested review from JacobSzwejbka and larryliu0820 as code owners September 2, 2025 22:22

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025

facebook-github-bot added the fb-exported label Sep 2, 2025

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Sep 2, 2025

Add program-data separation to pybindings (pytorch#13886)

fbe5a98

Summary: Pull Request resolved: pytorch#13886 Add support for optional data path for pybindings. Differential Revision: D76353209

lucylq force-pushed the export-D76353209 branch from 26a1dad to fbe5a98 Compare September 2, 2025 22:26

JacobSzwejbka reviewed Sep 2, 2025

View reviewed changes

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Sep 2, 2025

Add program-data separation to pybindings (pytorch#13886)

599a6e1

Summary: Add support for optional data path for pybindings. Differential Revision: D76353209

lucylq force-pushed the export-D76353209 branch from fbe5a98 to 599a6e1 Compare September 2, 2025 23:06

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Sep 2, 2025

Add program-data separation to pybindings (pytorch#13886)

5b4cb9a

Summary: Add support for optional data path for pybindings. Differential Revision: D76353209

lucylq force-pushed the export-D76353209 branch from 599a6e1 to 5b4cb9a Compare September 2, 2025 23:42

JacobSzwejbka approved these changes Sep 3, 2025

View reviewed changes

mergennachin reviewed Sep 3, 2025

View reviewed changes

lucylq force-pushed the export-D76353209 branch from 5b4cb9a to 36eb4be Compare September 8, 2025 03:05

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Sep 8, 2025

Add program-data separation to pybindings (pytorch#13886)

36eb4be

Summary: Add support for optional data path for pybindings. Reviewed By: JacobSzwejbka Differential Revision: D76353209

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Sep 8, 2025

Add program-data separation to pybindings (pytorch#13886)

a91be3a

Summary: Add support for optional data path for pybindings. Reviewed By: JacobSzwejbka Differential Revision: D76353209

lucylq force-pushed the export-D76353209 branch from 36eb4be to a91be3a Compare September 8, 2025 03:06

Add program-data separation to pybindings (pytorch#13886)

8eb077b

Summary: Pull Request resolved: pytorch#13886 Pull request resolved: pytorch#13886 Add support for optional data path for pybindings. Reviewed By: JacobSzwejbka Differential Revision: D76353209

lucylq force-pushed the export-D76353209 branch from a91be3a to 8eb077b Compare September 8, 2025 03:09

facebook-github-bot merged commit 6c12956 into pytorch:main Sep 8, 2025
116 of 118 checks passed

	def load_program(
	self,
	data: Union[bytes, bytearray, BinaryIO, Path, str],
	*,
	verification: Verification = Verification.InternalConsistency,
	) -> Program:

Add program-data separation to pybindings #13886

Add program-data separation to pybindings #13886

Uh oh!

Conversation

lucylq commented Sep 2, 2025

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

pytorch-bot bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13886

❌ 1 New Failure

Uh oh!

JacobSzwejbka Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

lucylq Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

mergennachin Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

lucylq Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergennachin left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 8, 2025

Uh oh!

facebook-github-bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

This PR needs a `release notes:` label

pytorch-bot bot commented Sep 2, 2025 •

edited

Loading

lucylq Sep 8, 2025 •

edited

Loading