Skip to content

Enforce range setting only used with per-channel #13889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

Enforce range setting only used with per-channel #13889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions examples/qualcomm/oss_scripts/llama/range_setting_pt2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,13 @@ def make_custom_quantizer(
per_channel_linear=True,
act_observer=MinMaxObserver,
)
if range_setting in ("mse_weight_only", "mse_with_act_loss", "na"):
if range_setting == "na":
observer = PerChannelMinMaxObserver
elif range_setting == "mse_weight_only":
if range_setting in ("mse_weight_only", "mse_with_act_loss"):
assert (
quant_dtype != QuantDtype.use_16a4w_block
), "Range setting only supported for per-channel quantization"
if range_setting == "mse_weight_only":
observer = PerChannelMSEObserver.with_args(
**{"steps": 200, "use_mse": True}
**{"steps": 1600, "use_mse": True}
)
else:
observer = PerChannelFixedQParamsObserver.with_args(**{"eps": 2**-12})
Expand Down
Loading