Skip to content

Arm backend: Refactor check_platform_support #13904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+38 −12
Merged

Arm backend: Refactor check_platform_support #13904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions backends/arm/scripts/utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,37 @@ function patch_repo() {
echo -e "[${FUNCNAME[0]}] Patched ${name} @ $(git describe --all --long 2> /dev/null) in ${repo_dir} dir.\n"
popd
}

function check_platform_support() {
# No args
# Exits with return code 1 if the platform is unsupported

# Make sure we are on a supported platform
if [[ "${ARCH}" != "x86_64" ]] && [[ "${ARCH}" != "aarch64" ]] \
&& [[ "${ARCH}" != "arm64" ]]; then
echo "[main] Error: only x86-64 & aarch64 architecture is supported for now!"
exit 1
fi
}

function check_os_support() {
# No args
# Exits with return code 1 if invalid combination of platform and os

# Check valid combinations of OS and platform

# Linux on x86_64
if [[ "${ARCH}" == "x86_64" ]] && [[ "${OS}" != "Linux" ]]; then
echo "Error: Only Linux is supported on x86_64"
exit 1
fi

# Linux on arm64/aarch64
# Darwin on arm64/aarch64
if [[ "${ARCH}" == "aarch64" ]] || [[ "${ARCH}" == "arm64" ]]; then
if [[ "${OS}" != "Darwin" ]] || [[ "${OS}" != "Linux" ]]; then
echo "Error: Only Linux and Darwin are supported on arm64"
exit 1
fi
fi
}
16 changes: 4 additions & 12 deletions examples/arm/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,15 +347,6 @@ function create_setup_path(){
fi
}

function check_platform_support() {
# Make sure we are on a supported platform
if [[ "${ARCH}" != "x86_64" ]] && [[ "${ARCH}" != "aarch64" ]] \
&& [[ "${ARCH}" != "arm64" ]]; then
echo "[main] Error: only x86-64 & aarch64 architecture is supported for now!"
exit 1
fi
}


########
### main
Expand All @@ -367,9 +358,13 @@ if [[ $is_script_sourced -eq 0 ]]; then

check_options "$@"

# Import utils
source $et_dir/backends/arm/scripts/utils.sh
source $et_dir/backends/arm/scripts/fvp_utils.sh

echo "[main]: Checking platform and os"
check_platform_support
check_os_support

cd "${script_dir}"

Expand All @@ -387,9 +382,6 @@ if [[ $is_script_sourced -eq 0 ]]; then
echo "enable-vela=${enable_vela}"
echo "mlsdk-manifest-url=${mlsdk_manifest_url}"

# Import utils
source $et_dir/backends/arm/scripts/utils.sh

# Select appropriate toolchain
select_toolchain

Expand Down
Loading