Replace aten linalg svd with cadence version. #13907
Merged
+84
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13907
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit faffa5a with merge base c22a2b0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D81199281 |
This PR needs a
|
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 3, 2025
Summary: Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Differential Revision: D81199281
hsharma35
force-pushed
the
export-D81199281
branch
from
3c46dd2 to
dd4b600
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81199281 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: pytorch#13907 Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Differential Revision: D81199281
hsharma35
force-pushed
the
export-D81199281
branch
2 times, most recently
from
ef0a712 to
ca60a86
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 4, 2025
Summary: Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Differential Revision: D81199281
|
This pull request was exported from Phabricator. Differential Revision: D81199281 |
hsharma35
requested review from
mcremon-meta,
skrtskrtfb and
zonglinpeng
and removed request for
mcremon-meta and
skrtskrtfb
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Reviewed By: DrJessop Differential Revision: D81199281
hsharma35
force-pushed
the
export-D81199281
branch
from
ca60a86 to
37ddebe
Compare
Summary: Update the module call graph for program builder so we get a valid edge/executorch program. Differential Revision: D77341475
hsharma35
force-pushed
the
export-D81199281
branch
from
37ddebe to
4e5de37
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Reviewed By: wahmed991, DrJessop Differential Revision: D81199281
|
This pull request was exported from Phabricator. Differential Revision: D81199281 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Pull Request resolved: pytorch#13907 Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Reviewed By: wahmed991, DrJessop Differential Revision: D81199281
hsharma35
force-pushed
the
export-D81199281
branch
from
4e5de37 to
01d613d
Compare
mcremon-meta
approved these changes
Sep 9, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Reviewed By: mcremon-meta, wahmed991, DrJessop Differential Revision: D81199281
hsharma35
force-pushed
the
export-D81199281
branch
from
01d613d to
47cbece
Compare
Summary: Pull Request resolved: pytorch#13907 Adds a replacement pass for `aten::_linalg_svd.default`. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs. Reviewed By: mcremon-meta, wahmed991, DrJessop Differential Revision: D81199281
|
This pull request was exported from Phabricator. Differential Revision: D81199281 |
hsharma35
force-pushed
the
export-D81199281
branch
from
47cbece to
faffa5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds a replacement pass for
aten::_linalg_svd.default. This op produces non-contiguous outputs so we replace it with cadence version that produces contiguous outputs.Differential Revision: D81199281