Skip to content

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Sep 3, 2025

  • Add _serialize_operator() function to NodeVisitor
  • Enable passing of DebugHook to NodeVisitor if enabled
  • Add option dump_debug_info to ArmCompileSpecBuilder

Change-Id: I9dc8da50a7ef16053b778ab33a03a990035de5ad

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

…ation

* Add _serialize_operator() function to NodeVisitor
* Enable passing of DebugHook to NodeVisitor if enabled
* Add option dump_debug_info to ArmCompileSpecBuilder

Change-Id: I9dc8da50a7ef16053b778ab33a03a990035de5ad
@tom-arm tom-arm requested a review from digantdesai as a code owner September 3, 2025 15:31
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13908

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit 0137d02 with merge base f8a422c (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Sep 3, 2025
@zingo zingo merged commit ad19cb8 into pytorch:main Sep 3, 2025
247 of 264 checks passed
self.tosa_spec = tosa_spec
self.debug_hook = debug_hook

def _serialize_operator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extend tosa_graph and not overload node visitor with this method?
The tosa_graph_torch (let's say) constructor takes debug_hook or other args and prepares a "graph", through addOperator like methods, which can be observed independently just like an FX graph.

Just an idea, don't want to block this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion Digant. I like the idea, I think it would look a bit cleaner

I can look into this, there will be one/two more commits to finalise this feature. So I think there is scope to incorporate this.

@tom-arm tom-arm deleted the add_debug_data_capture branch September 18, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants