Skip to content

Static attention batch size > 1 #13919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Static attention batch size > 1 #13919

merged 1 commit into from
Sep 4, 2025

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Sep 3, 2025

Summary: For QAT with batches. The exported QAT graph can't currently be reexported to have batch size 1 for inference, need to load state dict instead, Naveen to verify this works.

Reviewed By: telgamal-1, navsud

Differential Revision: D81245500

@sxu @facebook-github-bot
Static attention batch size > 1
7bfb51f 
Summary: For QAT with batches. The exported QAT graph can't currently be reexported to have batch size 1 for inference, need to load state dict instead, Naveen to verify this works.

Reviewed By: telgamal-1, navsud

Differential Revision: D81245500
@sxu sxu requested review from jackzhxng and lucylq as code owners September 3, 2025 20:03
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13919

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 7bfb51f with merge base 874d3c1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81245500

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu sxu requested review from billmguo and navsud September 3, 2025 20:04
@limintang limintang self-requested a review September 3, 2025 20:06
@facebook-github-bot facebook-github-bot merged commit 9cc092c into pytorch:main Sep 4, 2025
118 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limintang limintang limintang approved these changes

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@navsud navsud Awaiting requested review from navsud

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sxu @facebook-github-bot @limintang @billmguo