Arm backend: Fix broken logic when checking os in utils.sh #13939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic was flawed due to incorrect use of the logical OR operator. This condition will always evaluate to true because an OS cant be both Darwin and Linux simultaneously. Signed-off-by: per.held@arm.com Change-Id: I562d715dba34b3eaf91351ba245b20767a634358
perheld
added
ciflow/trunk
module: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13939
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 656b62a with merge base ea5cf49 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
zingo
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was flawed due to incorrect use of the logical OR operator.
This condition will always evaluate to true because an OS cant be both Darwin and Linux simultaneously.
Signed-off-by: per.held@arm.com
Change-Id: I562d715dba34b3eaf91351ba245b20767a634358