Skip to content

Allow custom ops to log outputs and profiling events for etdump #14010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Allow custom ops to log outputs and profiling events for etdump #14010

merged 1 commit into from
Sep 8, 2025

Conversation

kimishpatel
Copy link
Contributor

Summary:
Our logging and profiling current doesnt work with custom ops registered via EXECUTORCH_LIBRARY macro.
This diff fixes that. It requires building the sources for the custom op libs with event tracing enabled.

Reviewed By: Gasoonjia

Differential Revision: D81131610

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14010

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 707033a with merge base 2845fd3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81131610

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel @facebook-github-bot
Allow custom ops to log outputs and profiling events for etdump
707033a 
Summary:
Our logging and profiling current doesnt work with custom ops registered via EXECUTORCH_LIBRARY macro.
This diff fixes that. It requires building the sources for the custom op libs with event tracing enabled.

Reviewed By: Gasoonjia

Differential Revision: D81131610
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81131610

@facebook-github-bot facebook-github-bot merged commit 855c083 into pytorch:main Sep 8, 2025
116 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gasoonjia Gasoonjia Gasoonjia approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimishpatel @facebook-github-bot @Gasoonjia