Skip to content

Conversation

jirioc
Copy link
Collaborator

@jirioc jirioc commented Sep 5, 2025

Summary

Adding missing portable lib import.

Test plan

This is a fix for broken NXP unit tests.

cc @digantdesai @JakeStevens @robert-kalmar

Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14014

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 19ea5c0 with merge base 3899beb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@jirioc jirioc requested a review from robert-kalmar September 5, 2025 17:26
@jirioc jirioc added release notes: nxp Changes to the NXP Neutron backend delegate ciflow/trunk labels Sep 5, 2025
Copy link

pytorch-bot bot commented Sep 5, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Sep 5, 2025
@jirioc jirioc requested a review from digantdesai September 5, 2025 17:33
@robert-kalmar robert-kalmar added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Sep 5, 2025
@mergennachin mergennachin self-requested a review September 6, 2025 16:15
@mergennachin mergennachin merged commit 79744f0 into pytorch:main Sep 6, 2025
136 of 151 checks passed
@jirioc jirioc deleted the EIEX-525-fix-broken-unit-tests branch September 8, 2025 06:51
@digantdesai
Copy link
Contributor

Thank you! Why we didn't see this in the CI?

@mergennachin mergennachin mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants