Skip to content

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #13879 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/319/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/319/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/318/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/319/orig
@diff-train-skip-merge

@pytorchbot pytorchbot requested a review from SS-JIA as a code owner September 8, 2025 00:05
Copy link

pytorch-bot bot commented Sep 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14044

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2025
@SS-JIA SS-JIA force-pushed the gh/SS-JIA/318/orig branch from a18f88d to 7ae1a95 Compare September 8, 2025 02:03
Base automatically changed from gh/SS-JIA/318/orig to main September 8, 2025 02:06
Pull Request resolved: #13879

max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation.
ghstack-source-id: 308092876

Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/)
@SS-JIA SS-JIA force-pushed the gh/SS-JIA/319/orig branch from ea8890b to 2f3e80d Compare September 8, 2025 02:08
Copy link

github-actions bot commented Sep 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA SS-JIA merged commit 8da72c3 into main Sep 8, 2025
112 of 113 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/319/orig branch September 8, 2025 02:09
@mergennachin mergennachin mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants