[ET-VK] Fast path for choose_qparams #14045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14045
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
SS-JIA
force-pushed
the
gh/SS-JIA/319/orig
branch
from
ea8890b to
2f3e80d
Compare
Pull Request resolved: #14019 The current implementations of `choose_qparams` are too slow to be practically usable. As a temporary workaround to unblock LLM optimizations, this diff/PR introduces a fast path for computing per-channel quantization parameters for 2D matrices in the form of the choose_qparams_per_row shader. ghstack-source-id: 308092877 @exported-using-ghexport Differential Revision: [D81800024](https://our.internmc.facebook.com/intern/diff/D81800024/)
SS-JIA
force-pushed
the
gh/SS-JIA/320/orig
branch
from
2ac3676 to
47a8a9f
Compare
SS-JIA
approved these changes
Sep 8, 2025
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14019 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/320/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/320/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/319/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/320/orig
@diff-train-skip-merge