custom fbcode serialize stage to run FVP internally on arm ops tests #14070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14070
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 7 PendingAs of commit 70ed1b1 with merge base 5a1c117 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81159036 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
@pytorchbot label "topic: not user facing" |
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
2419440 to
575cf43
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81159036 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
575cf43 to
fc8afbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81159036 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
fc8afbc to
e00a87f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81159036 |
3l1
added a commit
that referenced
this pull request
Sep 11, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
3l1
force-pushed
the
export-D81159036
branch
from
e00a87f to
e9a5841
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81159036 |
3l1
added a commit
that referenced
this pull request
Sep 11, 2025
…14070) Summary: Pull Request resolved: #14070 update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
3l1
force-pushed
the
export-D81159036
branch
from
e9a5841 to
b7d2566
Compare
digantdesai
reviewed
Sep 11, 2025
backends/arm/test/targets.bzl
Outdated
| test_file_name = paths.basename(test_file) | ||
| test_name = test_file_name.replace("test_", "").replace(".py", "") | ||
|
|
||
digantdesai
reviewed
Sep 11, 2025
| aten_op, | ||
| exir_ops=[], | ||
| run_on_fvp=False, | ||
| run_on_fvp=True, |
There was a problem hiding this comment.
was there a reason it was disabled in OSS in the first place? If CI is clean I am ok with this PR enabling this.
There was a problem hiding this comment.
also add @common.XfailIfNoCorstone300 as a decorator?
digantdesai
approved these changes
Sep 11, 2025
There was a problem hiding this comment.
Thank @3l1!
LGTM, stamping to unblock but need some small fixes. And make sure the CI is clean.
3l1
added a commit
that referenced
this pull request
Sep 11, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
3l1
force-pushed
the
export-D81159036
branch
from
b7d2566 to
48c37c9
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
c41d23d to
8aad4a1
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
8aad4a1 to
4bf39fd
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
4bf39fd to
c4de978
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
c4de978 to
05f1db3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
05f1db3 to
3d7be98
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
3d7be98 to
af5a691
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 14, 2025
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
af5a691 to
4b9894d
Compare
…14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: digantdesai Differential Revision: D81159036
facebook-github-bot
force-pushed
the
export-D81159036
branch
from
4b9894d to
70ed1b1
Compare
mergennachin
approved these changes
Sep 15, 2025
|
macos jobs are already fixed in main, merging |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…ytorch#14070) Summary: update the codebase to allow a system whereby: - the test inventory in https://www.internalfb.com/code/fbsource/fbcode/executorch/backends/arm/test/ops/, which until now runs on open source CI can all be exercised internally on our internal diff-time sandcastle and CI runs - those tests can **transparently** switch between running an internal version of FVP using Meta's FVP runtimes, build configs and artifacts when run in fbsrouce, but then use the open-source FVp runtime when executed in github opens-ource CI Differential Revision: D81159036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
update the codebase to allow a system whereby:
Differential Revision: D81159036