forward fix for D81697327 #14088
Merged
forward fix for D81697327 #14088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this diff solves some issues raised after we introduced dim order variant clone op. Majorly: 1. make sure turning recipe have consistent _skip_dim_order flag between to_edge stage and lowering stage in Modai. 2. update constant_prop_pass to introduce expected variant of clone op in different dim order schema 3. register _clone_dim_order to vulkan. Differential Revision: [D81951792](https://our.internmc.facebook.com/intern/diff/D81951792/) [ghstack-poisoned]
Gasoonjia
requested review from
JacobSzwejbka,
SS-JIA and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14088
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cd461ea with merge base 6c12956 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Gasoonjia
added a commit
that referenced
this pull request
Sep 8, 2025
this diff solves some issues raised after we introduced dim order variant clone op. Majorly: 1. make sure turning recipe have consistent _skip_dim_order flag between to_edge stage and lowering stage in Modai. 2. update constant_prop_pass to introduce expected variant of clone op in different dim order schema 3. register _clone_dim_order to vulkan. Differential Revision: [D81951792](https://our.internmc.facebook.com/intern/diff/D81951792/) ghstack-source-id: 308291671 Pull Request resolved: #14088
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81951792 |
This PR needs a
|
cccclai
approved these changes
Sep 9, 2025
this diff solves some issues raised after we introduced dim order variant clone op. Majorly: 1. make sure turning recipe have consistent _skip_dim_order flag between to_edge stage and lowering stage in Modai. 2. update constant_prop_pass to introduce expected variant of clone op in different dim order schema 3. register _clone_dim_order to vulkan. Differential Revision: [D81951792](https://our.internmc.facebook.com/intern/diff/D81951792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Sep 9, 2025
Pull Request resolved: #14088 this diff solves some issues raised after we introduced dim order variant clone op. Majorly: 1. make sure turning recipe have consistent _skip_dim_order flag between to_edge stage and lowering stage in Modai. 2. update constant_prop_pass to introduce expected variant of clone op in different dim order schema 3. register _clone_dim_order to vulkan. ghstack-source-id: 308397776 @exported-using-ghexport Differential Revision: [D81951792](https://our.internmc.facebook.com/intern/diff/D81951792/)
|
This pull request was exported from Phabricator. Differential Revision: D81951792 |
facebook-github-bot
merged commit 266ffdd
into
gh/gasoonjia/39/base
115 of 118 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
mergennachin
pushed a commit
that referenced
this pull request
Sep 9, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14088 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/39/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/39/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/39/orig @diff-train-skip-merge Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
this diff solves some issues raised after we introduced dim order variant clone op. Majorly:
Differential Revision: D81951792