Skip to content

Conversation

kirklandsign
Copy link
Contributor

Summary

Just use generate()

Test plan

CI

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14101

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 55 Pending

As of commit f6f69b4 with merge base 9fa1b27 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
Copy link

github-actions bot commented Sep 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign changed the base branch from main to start-pos-api-llava-5 September 9, 2025 23:40
@kirklandsign kirklandsign changed the title Start pos api llava 6 No longer need generateFromPos API Sep 9, 2025
Base automatically changed from start-pos-api-llava-5 to main September 10, 2025 18:37
@kirklandsign kirklandsign marked this pull request as ready for review September 10, 2025 18:41
@kirklandsign kirklandsign merged commit 9b6387f into main Sep 10, 2025
280 of 288 checks passed
@kirklandsign kirklandsign deleted the start-pos-api-llava-6 branch September 10, 2025 19:41
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants