Skip to content

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Sep 10, 2025

Stack from ghstack (oldest at bottom):

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under QuantizedLinear.cpp, the operators implemented in QuantizedLinearQGANW.cpp and QuantizedLinear_QTA8A_QGA4W.cpp are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

  • et_vk.linear_weight_int4.default
  • et_vk.linear_qta8a_qga4w.default

AOT export logic needed to support those ops are also removed.

Differential Revision: D82120824

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14151

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 42 Unrelated Failures

As of commit a63a9b4 with merge base 598ba46 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA pushed a commit that referenced this pull request Sep 10, 2025
As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)

ghstack-source-id: 308785943
Pull Request resolved: #14151
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82120824

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ions"

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Sep 10, 2025
Pull Request resolved: #14151

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)
ghstack-source-id: 308791208
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82120824

…ions"

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Sep 11, 2025
Pull Request resolved: #14151

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.
ghstack-source-id: 308939585

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82120824

@facebook-github-bot facebook-github-bot merged commit b304076 into gh/SS-JIA/326/base Sep 11, 2025
244 of 290 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/326/head branch September 11, 2025 04:51
SS-JIA pushed a commit that referenced this pull request Sep 11, 2025
Pull Request resolved: #14151

As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required.

This diff removes all code related to the operators implemented in those files, namely:

* `et_vk.linear_weight_int4.default`
* `et_vk.linear_qta8a_qga4w.default`

AOT export logic needed to support those ops are also removed.
ghstack-source-id: 308939585

Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants