NXP backend: Move optimization in keep_one_empty_buffer.py to Model builder #14163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14163
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled JobsAs of commit 01d03ca with merge base eec95d0 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "module: nxp" "release notes: nxp" |
pytorch-bot
bot
added
module: nxp
robert-kalmar
force-pushed
the
feature/nxg11066/EIEX-517-Move-optimization-in-keep_one_empty_buffer.py-to-model-builder
branch
from
be20b38 to
aeef112
Compare
roman-janik-nxp
changed the title
robert-kalmar
force-pushed
the
feature/nxg11066/EIEX-517-Move-optimization-in-keep_one_empty_buffer.py-to-model-builder
branch
from
aeef112 to
72c82db
Compare
|
There are some lintrunner issues. @roman-janik-nxp, can you fix it? |
robert-kalmar
approved these changes
Sep 12, 2025
roman-janik-nxp
force-pushed
the
feature/nxg11066/EIEX-517-Move-optimization-in-keep_one_empty_buffer.py-to-model-builder
branch
from
72c82db to
4fa822f
Compare
Done. |
…in-keep_one_empty_buffer.py-to-model-builder
robert-kalmar
deleted the
feature/nxg11066/EIEX-517-Move-optimization-in-keep_one_empty_buffer.py-to-model-builder
branch
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…uilder (pytorch#14163) ### Summary Move optimization in keep_one_empty_buffer.py to IR Model builder. This functionality is not an optimization, but a required housekeeping step to build a valid IR model for Neutron Converter. ### Test plan All tests where a subgraph is delegated to Neutron.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move optimization in keep_one_empty_buffer.py to IR Model builder. This functionality wasn't an optimization, but a required step needed to successfully build a IR model for delegation.
Test plan
All tests where a subgraph is delegated to Neutron.
cc @robert-kalmar @roman-janik-nxp @StrycekSimon @jirioc @MartinPavella