Skip to content

Conversation

manuelcandales
Copy link
Contributor

Summary:
This diff adds support for BFloat16 dtype in ExecuTorch's exir dialect by updating the type system and operator constraints.

Previously, BFloat16 inputs required disabling IR validity checks with _check_ir_validity=False to work around the lack of proper type system support.

The changes include:

  • Adding torch.bfloat16: "BFloat16" mapping in the supported dtypes configuration
  • Updating edge.yaml to include BFloat16 anywhere that Half is supported

Differential Revision: D82129165

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14164

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 4 Unrelated Failures

As of commit bbf3095 with merge base 47acc87 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82129165

@manuelcandales manuelcandales added the release notes: exir Changes to any dialects and passes on these dialects, such as memory planning label Sep 10, 2025
manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Sep 10, 2025
Summary:

This diff adds support for BFloat16 dtype in ExecuTorch's exir dialect by updating the type system and operator constraints.

Previously, BFloat16 inputs required disabling IR validity checks with `_check_ir_validity=False` to work around the lack of proper type system support. 

The changes include:
- Adding `torch.bfloat16: "BFloat16"` mapping in the supported dtypes configuration
- Updating edge.yaml to include BFloat16 anywhere that Half is supported

Reviewed By: JacobSzwejbka

Differential Revision: D82129165
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82129165

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Sep 10, 2025
Summary:

This diff adds support for BFloat16 dtype in ExecuTorch's exir dialect by updating the type system and operator constraints.

Previously, BFloat16 inputs required disabling IR validity checks with `_check_ir_validity=False` to work around the lack of proper type system support. 

The changes include:
- Adding `torch.bfloat16: "BFloat16"` mapping in the supported dtypes configuration
- Updating edge.yaml to include BFloat16 anywhere that Half is supported

Reviewed By: JacobSzwejbka

Differential Revision: D82129165
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82129165

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Sep 10, 2025
Summary:

This diff adds support for BFloat16 dtype in ExecuTorch's exir dialect by updating the type system and operator constraints.

Previously, BFloat16 inputs required disabling IR validity checks with `_check_ir_validity=False` to work around the lack of proper type system support. 

The changes include:
- Adding `torch.bfloat16: "BFloat16"` mapping in the supported dtypes configuration
- Updating edge.yaml to include BFloat16 anywhere that Half is supported

Reviewed By: JacobSzwejbka

Differential Revision: D82129165
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82129165

Summary:

This diff adds support for BFloat16 dtype in ExecuTorch's exir dialect by updating the type system and operator constraints.

Previously, BFloat16 inputs required disabling IR validity checks with `_check_ir_validity=False` to work around the lack of proper type system support. 

The changes include:
- Adding `torch.bfloat16: "BFloat16"` mapping in the supported dtypes configuration
- Updating edge.yaml to include BFloat16 anywhere that Half is supported

Reviewed By: JacobSzwejbka

Differential Revision: D82129165
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82129165

@facebook-github-bot facebook-github-bot merged commit a7eefd0 into pytorch:main Sep 11, 2025
112 of 119 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82129165

Pull Request resolved: pytorch#14164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: exir Changes to any dialects and passes on these dialects, such as memory planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants