Compare full key value when retrieving named data #14165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14165
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 2 Pending, 3 Unrelated FailuresAs of commit bf92de2 with merge base 8a0a25b ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
This PR needs a
|
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
c22f51d to
6c8ab6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Pull Request resolved: pytorch#14165 Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
6c8ab6b to
f3fd39f
Compare
LeeOHzzZ
requested review from
JacobSzwejbka and
larryliu0820
as code owners
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
f3fd39f to
7878266
Compare
lucylq
approved these changes
Sep 10, 2025
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Reviewed By: lucylq Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
7878266 to
c543147
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Pull Request resolved: pytorch#14165 Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Reviewed By: lucylq Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
c543147 to
04730bc
Compare
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Reviewed By: lucylq Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
04730bc to
780acf8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
LeeOHzzZ
pushed a commit
to LeeOHzzZ/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Reviewed By: lucylq Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
fb821f2 to
b49a436
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
Summary: Compare full input key value when retrieving named data. Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10". Reviewed By: lucylq Differential Revision: D82129824
LeeOHzzZ
force-pushed
the
export-D82129824
branch
from
b49a436 to
bf92de2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82129824 |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D82129824 Pull Request resolved: pytorch#14165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Compare full input key value when retrieving named data.
Previous implementation iterates through the key values, comparing the input key value up to the length of the iterated key value length. This causes wrong data access when there is a key before this value and has partial match in the front part, e.g., "delegate_1" and "delegate_10".
Differential Revision: D82129824