Fix BFloat16 support for op_index #14167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14167
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 5 Unrelated FailuresAs of commit 07d5d12 with merge base 2805a81 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82134506 |
manuelcandales
added
the
release notes: none
SS-JIA
approved these changes
Sep 10, 2025
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Sep 10, 2025
Summary: Previously, the portable op index didn't support BFloat16 when all the indices were null. This PR fixes this, and adds comprehensive testing for this edge case. Reviewed By: SS-JIA Differential Revision: D82134506
manuelcandales
force-pushed
the
export-D82134506
branch
from
06bbb91 to
c4e40fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82134506 |
Summary: Previously, the portable op index didn't support BFloat16 when all the indices were null. This PR fixes this, and adds comprehensive testing for this edge case. Reviewed By: SS-JIA Differential Revision: D82134506
manuelcandales
force-pushed
the
export-D82134506
branch
from
c4e40fc to
07d5d12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82134506 |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D82134506 Pull Request resolved: pytorch#14167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, the portable op index didn't support BFloat16 when all the indices were null. This PR fixes this, and adds comprehensive testing for this edge case.
Differential Revision: D82134506