-
Notifications
You must be signed in to change notification settings - Fork 684
Revert "Arm backend: Refactor compile spec handling (#14111)" #14175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14175
Note: Links to docs will display an error until the docs builds have been completed. ❌ 33 New Failures, 3 Pending, 8 Unrelated FailuresAs of commit 9c100c2 with merge base 5d63bad ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Sep 10, 2025
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.) ghstack-source-id: 0688ea4 ghstack-comment-id: 3276337046 Pull-Request: #14175
mergennachin
approved these changes
Sep 10, 2025
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 10, 2025
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.) ghstack-source-id: ee95d6e ghstack-comment-id: 3276337046 Pull-Request: #14175
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…ytorch#14175) This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-no-td
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
release notes: api
Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
release notes: arm
Changes to the ARM backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)