Skip to content

Conversation

swolchok
Copy link
Contributor

This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Sep 10, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14175

Note: Links to docs will display an error until the docs builds have been completed.

❌ 33 New Failures, 3 Pending, 8 Unrelated Failures

As of commit 9c100c2 with merge base 5d63bad (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 10, 2025
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)


ghstack-source-id: 0688ea4
ghstack-comment-id: 3276337046
Pull-Request: #14175
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@swolchok swolchok added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) release notes: arm Changes to the ARM backend delegate labels Sep 10, 2025
Base automatically changed from gh/swolchok/566/head to main September 10, 2025 21:36
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 10, 2025
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)


ghstack-source-id: ee95d6e
ghstack-comment-id: 3276337046
Pull-Request: #14175
@swolchok swolchok merged commit f294074 into main Sep 11, 2025
74 of 117 checks passed
@swolchok swolchok deleted the gh/swolchok/567/head branch September 11, 2025 00:01
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
…ytorch#14175)

This reverts commit 29cec35. This broke
our internal Buck builds and I think revert/reapply will allow us to
ingest changes faster overall. (Have plans to get some Buck coverage in
GitHub CI that will prevent problems like this going forward soon.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants