Skip to content

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14126 by @abhinaykukkadapu
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/10/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/10/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/9/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/10/orig
@diff-train-skip-merge

…transform_passes definition to take exported program and method name.

Pull Request resolved: #14125

While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made:

- `pre_edge_transform_passes` is now renamed to `aten_transform_passes`
- `aten_transform_passes`: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgram
   - `aten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]`
- `edge_transform_passes`: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created.
   - `edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]`
ghstack-source-id: 308796607

Differential Revision: [D81730890](https://our.internmc.facebook.com/intern/diff/D81730890/)
Pull Request resolved: #14126

This diff adds QNN fp16 recipe and tests using htp simulator.

Fixes: #13101
ghstack-source-id: 308796609

Differential Revision: [D81945971](https://our.internmc.facebook.com/intern/diff/D81945971/)
@pytorchbot pytorchbot requested a review from cccclai as a code owner September 10, 2025 20:40
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14179

Note: Links to docs will display an error until the docs builds have been completed.

❌ 26 New Failures, 195 Pending, 37 Unrelated Failures

As of commit 610219f with merge base 0b78412 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
Base automatically changed from gh/abhinaykukkadapu/9/orig to main September 10, 2025 21:27
@abhinaykukkadapu abhinaykukkadapu merged commit 598ba46 into main Sep 10, 2025
218 of 288 checks passed
@abhinaykukkadapu abhinaykukkadapu deleted the gh/abhinaykukkadapu/10/orig branch September 10, 2025 21:27
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
…81945971

Co-authored-by: Abhinay Kukkadapu <abhinayk@meta.com>

Differential version: D81945971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants