Skip to content

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Sep 10, 2025

Summary

We will no longer pass startPos, bos, eos args. User doesn't need to know that.

For generate_from_pos with image and text prompts, it will add input prompts first, and then invoke generate()

Test plan

CI

cc @cbilgin

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14183

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Cancelled Jobs, 3 Pending, 1 Unrelated Failure

As of commit a036eb9 with merge base 47acc87 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@kirklandsign kirklandsign added the module: android Issues related to Android code, build, and execution label Sep 10, 2025
@kirklandsign kirklandsign marked this pull request as ready for review September 10, 2025 23:06
@kirklandsign kirklandsign added the release notes: android Android Java and JNI code label Sep 10, 2025
@kirklandsign kirklandsign merged commit 53b7ec5 into main Sep 11, 2025
119 of 125 checks passed
@kirklandsign kirklandsign deleted the start-pos-api-llava-8 branch September 11, 2025 01:26
@github-project-automation github-project-automation bot moved this from Todo to Done in ExecuTorch Android Sep 11, 2025
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
### Summary
We will no longer pass startPos, bos, eos args. User doesn't need to
know that.

For generate_from_pos with image and text prompts, it will add input
prompts first, and then invoke generate()

### Test plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution release notes: android Android Java and JNI code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants