Skip to content

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Sep 11, 2025

Summary

Fixes Llava not exporting with get_max_seq_len metadata method in the pte, which was happening because __post_init__ only works with @dataclass.

Testing

Exported a Llava pte and ran with the multimodal runner

Copy link

pytorch-bot bot commented Sep 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14192

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 4 Cancelled Jobs, 37 Pending

As of commit dd8fc32 with merge base f294074 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label Sep 11, 2025
@jackzhxng jackzhxng merged commit d4d1df7 into main Sep 11, 2025
293 of 311 checks passed
@jackzhxng jackzhxng deleted the jz/fix-metadata-method-export branch September 11, 2025 19:10
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Fixes Llava not exporting with `get_max_seq_len` metadata method in the
pte, which was happening because `__post_init__` only works with
`@dataclass`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants