Skip to content

Revert "Revert "Add qnn backend to pip packages (#13794)"" #14220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 11, 2025
Merged

Revert "Revert "Add qnn backend to pip packages (#13794)"" #14220

merged 19 commits into from
Sep 11, 2025

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Sep 11, 2025

Reverts #14212

@pytorch-bot pytorch-bot bot added the ci-no-td label Sep 11, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14220

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 236 Pending

As of commit 26e5eee with merge base 1ea9feb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai marked this pull request as draft September 11, 2025 15:43
@cccclai cccclai added this to the 1.0.0 milestone Sep 11, 2025
kimishpatel
kimishpatel approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment the lines that have changed compared to previous one

cccclai
cccclai commented Sep 11, 2025
View reviewed changes
backends/qualcomm/__init__.py Outdated
# If users have preinstalled QNN_SDK_ROOT, we will use it.
qnn_sdk_root_flag = os.getenv("QNN_SDK_ROOT", None)

if env_flag not in ("1", "true", "yes") and not qnn_sdk_root_flag and is_linux_x86():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimishpatel this line

cccclai
cccclai commented Sep 11, 2025
View reviewed changes
setup.py Outdated
is_linux_x86,
)

if is_linux_x86():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimishpatel and here

@cccclai cccclai marked this pull request as ready for review September 11, 2025 17:09
@cccclai cccclai merged commit f7df6b1 into main Sep 11, 2025
303 of 308 checks passed
@cccclai cccclai deleted the revert-14212-gh/swolchok/569/head branch September 11, 2025 23:59
cccclai added a commit that referenced this pull request Sep 12, 2025
@cccclai
Revert "Revert "Revert "Add qnn backend to pip packages (#13794)"" (#…
01ad4a8 
…14220)"

This reverts commit f7df6b1.
@cccclai cccclai mentioned this pull request Sep 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@swolchok swolchok Awaiting requested review from swolchok

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees
No one assigned
Labels
ci-no-td ciflow/binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cccclai @kimishpatel