Skip to content

pyre-fix #14241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2025
Merged

pyre-fix #14241

merged 1 commit into from
Sep 13, 2025

Conversation

metascroy
Copy link
Contributor

Summary: Fix pyre errors

Differential Revision: D82265586

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14241

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit ec07cba with merge base e6b9111 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 11, 2025
@metascroy @facebook-github-bot
pyre-fix (pytorch#14241)
70a095a 
Summary:

Forward fix for pyre errors in D82242003

Differential Revision: D82265586
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 11, 2025
@metascroy @facebook-github-bot
pyre-fix (pytorch#14241)
68f3cda 
Summary:

Forward fix for pyre errors in D82242003

Differential Revision: D82265586
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 11, 2025
@metascroy @facebook-github-bot
pyre-fix (pytorch#14241)
ad5f403 
Summary:
Pull Request resolved: pytorch#14241

Forward fix for pyre errors in D82242003

Differential Revision: D82265586
metascroy added a commit to metascroy/executorch that referenced this pull request Sep 11, 2025
@metascroy @facebook-github-bot
pyre-fix (pytorch#14241)
22ecd35 
Summary:

Forward fix for pyre errors in D82242003

Reviewed By: digantdesai

Differential Revision: D82265586
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

@metascroy @facebook-github-bot
Forward fix for D82242003 (pytorch#14241)
ec07cba 
Summary:

This fixes internal failures on D82242003:
* pyre errors 
* buck build --flagfile fbcode//mode/dev fbcode//executorch/examples/models/fb/llama4:ngtts_semantic_lm_xnnpack_quantized.pte

The second failure is because the old and new APIs have different behaviors when group_size is incompatible with the nn.Linear module's shape.  In the old API, it silently does not quantize the layer, whereas the new API is more explicit and throws an error.  This diff uses a filter_fn to restore the previous behavior.

Reviewed By: digantdesai

Differential Revision: D82265586
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265586.

@facebook-github-bot facebook-github-bot merged commit b5523cd into pytorch:main Sep 13, 2025
119 of 125 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@metascroy @StrycekSimon
pyre-fix
0cc8212 
Differential Revision: D82265586

Pull Request resolved: pytorch#14241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metascroy @facebook-github-bot @digantdesai