Skip to content

Arm Backend: Add visualization script for Arm models #14257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2025
Merged

Arm Backend: Add visualization script for Arm models #14257

merged 3 commits into from
Sep 15, 2025

Conversation

jmahbs
Copy link
Contributor

@jmahbs jmahbs commented Sep 12, 2025 •
edited by pytorch-bot bot
Loading

This PR enables the visualisation of a tosa flatbuffer file in the arm run.sh script. The model_explorer command line flag is added which launches model explorer, with the tosa adapter plugin - https://github.com/Arm/tosa-adapter-model-explorer.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@rainierwolfcastle @jmahbs
Add visualization script for Arm models
9138435 
Change-Id: I141fbade30ba06ce6b6a104000b833431e4bf243
@jmahbs jmahbs requested a review from digantdesai as a code owner September 12, 2025 13:43
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14257

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 994a990 with merge base dfd7f2a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@jmahbs
Copy link
Contributor Author

jmahbs commented Sep 12, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Sep 12, 2025
@zingo zingo added this to the 1.0.0 milestone Sep 12, 2025
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate ciflow/trunk and removed release notes: none Do not include this in the release notes labels Sep 12, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo zingo changed the title Add visualization script for Arm models Arm Backend: Add visualization script for Arm models Sep 12, 2025
@mergennachin mergennachin self-requested a review September 12, 2025 19:10
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D82330946.

digantdesai
digantdesai approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@mergennachin mergennachin merged commit 957915f into pytorch:main Sep 15, 2025
120 of 122 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@jmahbs @rainierwolfcastle @StrycekSimon
Arm Backend: Add visualization script for Arm models (pytorch#14257)
55e9fdf 
This PR enables the visualisation of a tosa flatbuffer file in the arm
`run.sh` script. The `model_explorer` command line flag is added which
launches model explorer, with the tosa adapter plugin -
https://github.com/Arm/tosa-adapter-model-explorer.


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Co-authored-by: Robert Taylor <robert.taylor3@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jmahbs @facebook-github-bot @digantdesai @zingo @mergennachin @rainierwolfcastle