Add CI for checking file size #14274
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14274
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 106 PendingAs of commit 4d3f622 with merge base 30a904b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
Might be nice to have this check in lintrunner also down the line. |
I think this check each file already. What does it mean by down the line? |
cccclai
force-pushed
the
lint_file_size
branch
from
7afeddc to
6febe36
Compare
| runner: linux.2xlarge | ||
| docker-image: ci-image:executorch-ubuntu-22.04-linter | ||
| submodules: false | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
IIRC 0 is unlimited. couldn't we make this some large (because it gates the maximum depth of a stack) but finite number, like say 50?
There was a problem hiding this comment.
I tried look up fetch-depth in both executorch and pytorch, and looks like all are defined as 0 or 1...I can't find definition for this variable so using the same as other jobs to be safe
| if: ${{ github.event_name == 'pull_request' }} | ||
| uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main | ||
| with: | ||
| runner: linux.2xlarge |
There was a problem hiding this comment.
do we have smaller runners we can use? this isn't particularly resource-intensive
There was a problem hiding this comment.
Tried linux.large and docker image pulling failed. Bump it to 2x
As title. xrefs will hang if the files change too much, however it's a bit hard to tell. Make file size check explicit. The rule is following 1. For all files, the file size can't be larger than 1MB 2. For images/vidoes, the files size can't be larger than 7MB 3. There is an exception list defined in the script if it's really needed
3 participants
As title. xrefs will hang if the files change too much, however it's a bit hard to tell. Make file size check explicit. The rule is following