Skip to content

Remove generate_from_pos since there's no user of it #14277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2025
Merged

Remove generate_from_pos since there's no user of it #14277

merged 2 commits into from
Sep 13, 2025

Conversation

larryliu0820
Copy link
Contributor

As titled, rely on CI jobs

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14277

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 5766ae2 with merge base 233063c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin
Copy link
Contributor

Doesn't this API adhere to the lifecycle policy? Stable, experimental, deprecated... ?

@mergennachin
Copy link
Contributor

We need at least two releases to deprecate an API since beta.

@larryliu0820
Copy link
Contributor Author

We need at least two releases to deprecate an API since beta.

It's marked as experimental though

lucylq
lucylq reviewed Sep 12, 2025
View reviewed changes
lucylq
lucylq reviewed Sep 12, 2025
View reviewed changes
lucylq
lucylq reviewed Sep 12, 2025
View reviewed changes
@larryliu0820 larryliu0820 merged commit a77c8df into main Sep 13, 2025
122 of 125 checks passed
@larryliu0820 larryliu0820 deleted the remove_pos branch September 13, 2025 00:55
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@larryliu0820 @StrycekSimon
Remove generate_from_pos since there's no user of it (pytorch#14277)
df60525 
As titled, rely on CI jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@larryliu0820 @mergennachin @lucylq @kirklandsign