Skip to content

Conversation

neuropilot-captain
Copy link
Collaborator

@neuropilot-captain neuropilot-captain commented Sep 15, 2025

Summary

Remove NeuronAdapter.h
Please don't update this branch if possible to prevent it from getting added back again, thanks.

Copy link

pytorch-bot bot commented Sep 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14296

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 8931b97 with merge base 0b3227f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai
Copy link
Contributor

cccclai commented Sep 15, 2025

Please don't update this branch if possible to prevent it from getting added back again

what does it mean?

@neuropilot-captain
Copy link
Collaborator Author

Please don't update this branch if possible to prevent it from getting added back again

what does it mean?

We previously have deleted the NeuronAdapter.h file in one of our commits, but after updating and merging with the main branch, it got added back in again (as the main branch have the file to be deleted).

@cccclai cccclai merged commit 7edb278 into pytorch:main Sep 15, 2025
122 of 125 checks passed
@cccclai
Copy link
Contributor

cccclai commented Sep 15, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

pytorchbot pushed a commit that referenced this pull request Sep 15, 2025
### Summary
Remove NeuronAdapter.h
Please don't update this branch if possible to prevent it from getting
added back again, thanks.

(cherry picked from commit 7edb278)
@pytorchbot
Copy link
Collaborator

Cherry picking #14296

The cherry pick PR is at #14322 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
### Summary
Remove NeuronAdapter.h
Please don't update this branch if possible to prevent it from getting
added back again, thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants