Skip to content

Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv1d_nlc #14310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv1d_nlc #14310

merged 1 commit into from
Sep 17, 2025
+429 −409

Conversation

ethansfng
Copy link
Contributor

Differential Revision: D82329465

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14310

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 43b565c with merge base 56659e4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 15, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
37ca2c3 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 15, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
2bceaca 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 15, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
54efe54 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 16, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
b7e2d35 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 16, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
ed70127 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 16, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
611797b 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 16, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
c5f4aa8 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 17, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
b0361db 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Reviewed By: mcremon-meta

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

ethansfng added a commit to ethansfng/executorch that referenced this pull request Sep 17, 2025
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
a31458d 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Reviewed By: mcremon-meta

Differential Revision: D82329465
@ethansfng @facebook-github-bot
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
43b565c 
…1d_nlc (pytorch#14310)

Summary: Pull Request resolved: pytorch#14310

Reviewed By: mcremon-meta

Differential Revision: D82329465
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82329465.

@facebook-github-bot facebook-github-bot merged commit 97e2299 into pytorch:main Sep 17, 2025
125 of 128 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@ethansfng @StrycekSimon
Rename conv -> conv2d, conv1d_nchw -> conv1d_ncl, conv1d_nhwc -> conv…
b880915 
…1d_nlc

Differential Revision: D82329465

Pull Request resolved: pytorch#14310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcremon-meta mcremon-meta mcremon-meta approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethansfng @facebook-github-bot @mcremon-meta