Skip to content

Conversation

zonglinpeng
Copy link
Contributor

Summary:
Titled.
TODO: refactor the facto util file to dedup.

Differential Revision: D82476715

Copy link

pytorch-bot bot commented Sep 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14313

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 007e9bd with merge base 30a904b (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 15, 2025
Summary:

Titled.
TODO: refactor the facto util file to dedup.

Differential Revision: D82476715
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715.

Summary:

Use a simple by hacky method to limit the size by rank:
`size = 3999^(1/rank)`

TODO: add coverage to remove the hack of size constraint to

Differential Revision: D82476715
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715.

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 15, 2025
Summary:

Use a simple by hacky method to limit the size by rank:
`size = 3999^(1/rank)`

TODO: add coverage to remove the hack of size constraint to

Reviewed By: hsharma35

Differential Revision: D82476715
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 16, 2025
Summary:

Use a simple by hacky method to limit the size by rank:
`size = 3999^(1/rank)`

TODO: add coverage to remove the hack of size constraint to

Reviewed By: hsharma35

Differential Revision: D82476715
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 16, 2025
Summary:

Use a simple by hacky method to limit the size by rank:
`size = 3999^(1/rank)`

TODO: add coverage to remove the hack of size constraint to

Reviewed By: hsharma35

Differential Revision: D82476715
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 16, 2025
Summary:

Use a simple by hacky method to limit the size by rank:
`size = 3999^(1/rank)`

TODO: add coverage to remove the hack of size constraint to

Reviewed By: hsharma35

Differential Revision: D82476715
@facebook-github-bot facebook-github-bot merged commit c1b7ec5 into pytorch:main Sep 17, 2025
124 of 127 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82476715

Pull Request resolved: pytorch#14313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants