-
Notifications
You must be signed in to change notification settings - Fork 684
limited facto tensor size to be less than 4000 bytes #14313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limited facto tensor size to be less than 4000 bytes #14313
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14313
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 007e9bd with merge base 30a904b ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715. |
This PR needs a
|
Summary: Titled. TODO: refactor the facto util file to dedup. Differential Revision: D82476715
2dedb58
to
086537c
Compare
@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715. |
Summary: Use a simple by hacky method to limit the size by rank: `size = 3999^(1/rank)` TODO: add coverage to remove the hack of size constraint to Differential Revision: D82476715
086537c
to
007e9bd
Compare
@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82476715. |
Summary: Use a simple by hacky method to limit the size by rank: `size = 3999^(1/rank)` TODO: add coverage to remove the hack of size constraint to Reviewed By: hsharma35 Differential Revision: D82476715
Summary: Use a simple by hacky method to limit the size by rank: `size = 3999^(1/rank)` TODO: add coverage to remove the hack of size constraint to Reviewed By: hsharma35 Differential Revision: D82476715
Summary: Use a simple by hacky method to limit the size by rank: `size = 3999^(1/rank)` TODO: add coverage to remove the hack of size constraint to Reviewed By: hsharma35 Differential Revision: D82476715
Summary: Use a simple by hacky method to limit the size by rank: `size = 3999^(1/rank)` TODO: add coverage to remove the hack of size constraint to Reviewed By: hsharma35 Differential Revision: D82476715
Differential Revision: D82476715 Pull Request resolved: pytorch#14313
Summary:
Titled.
TODO: refactor the facto util file to dedup.
Differential Revision: D82476715