Skip to content

limit facto to 4000 bytes than numel #14318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2025
Merged

limit facto to 4000 bytes than numel #14318

merged 3 commits into from
Sep 17, 2025

Conversation

zonglinpeng
Copy link
Contributor

Summary: convert numel to bytes based on dtype

Reviewed By: hsharma35

Differential Revision: D82483935

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14318

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 48 Pending

As of commit 3fca656 with merge base 75cb986 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82483935.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Zonglin Peng added 2 commits September 16, 2025 14:37
@facebook-github-bot
limit facto tensor size to random 4000 numel
28901cc 
Differential Revision: D82483921
@facebook-github-bot
limit facto to 4000 bytes than numel
ddc7ace 
Differential Revision: D82483935
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 16, 2025
@zonglinpeng @facebook-github-bot
limit facto to 4000 bytes than numel (pytorch#14318)
7cf7cc2 
Summary:

convert numel to bytes based on dtype

Reviewed By: hsharma35

Differential Revision: D82483935
@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82483935.

@facebook-github-bot
Copy link
Contributor

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82483935.

@facebook-github-bot facebook-github-bot merged commit 7d5c886 into pytorch:main Sep 17, 2025
125 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@zonglinpeng @StrycekSimon
limit facto to 4000 bytes than numel
5d2b812 
Differential Revision: D82483935

Pull Request resolved: pytorch#14318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsharma35 hsharma35 hsharma35 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zonglinpeng @facebook-github-bot @hsharma35