Skip to content

Qualcomm AI Engine Direct - Cat Fix #14325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Qualcomm AI Engine Direct - Cat Fix #14325

merged 2 commits into from
Sep 17, 2025

Conversation

winskuo-quic
Copy link
Collaborator

Summary

Fix op cat to retrieve the right node.

Test plan

CI pass

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14325

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7d4953c with merge base c1b7ec5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@billmguo has imported this pull request. If you are a Meta employee, you can view this in D82548601.

@cccclai
Copy link
Contributor

cccclai commented Sep 16, 2025

Do you have an example test case?

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/debug_min_vit_model branch from 375cbd7 to 7d4953c Compare September 17, 2025 09:48
@winskuo-quic
Copy link
Collaborator Author

Thanks for reviewing the PR. I have added a unit test. Please have a look

cccclai
cccclai approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D82548601.

@cccclai cccclai merged commit facf35d into pytorch:main Sep 17, 2025
126 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@winskuo-quic @StrycekSimon
Qualcomm AI Engine Direct - Cat Fix (pytorch#14325)
fca7791 
### Summary
Fix op cat to retrieve the right node.

### Test plan
CI pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billmguo billmguo billmguo approved these changes

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@winskuo-quic @facebook-github-bot @cccclai @billmguo