Skip to content

Conversation

winskuo-quic
Copy link
Collaborator

@winskuo-quic winskuo-quic commented Sep 16, 2025

Summary

Rope fix

Test plan

CI Passes

cc: @haowhsu-quic

Copy link

pytorch-bot bot commented Sep 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14328

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit a25a4a1 with merge base eec95d0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
I think current mainline's static LLM model has some bug.
If the branch cut has already happened, could we also cherry-pick this PR?
Thanks

@cccclai cccclai merged commit dd7f4d2 into pytorch:main Sep 16, 2025
130 of 133 checks passed
@cccclai
Copy link
Contributor

cccclai commented Sep 16, 2025

Hi @cccclai, I think current mainline's static LLM model has some bug. If the branch cut has already happened, could we also cherry-pick this PR? Thanks

Yeah will do

@cccclai
Copy link
Contributor

cccclai commented Sep 16, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

@cccclai
Copy link
Contributor

cccclai commented Sep 16, 2025

You can actually follow #14288 to cherry pick too

pytorchbot pushed a commit that referenced this pull request Sep 16, 2025
### Summary
Rope fix

### Test plan
CI Passes

cc: @haowhsu-quic
(cherry picked from commit dd7f4d2)
@pytorchbot
Copy link
Collaborator

Cherry picking #14328

The cherry pick PR is at #14346 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@winskuo-quic
Copy link
Collaborator Author

You can actually follow #14288 to cherry pick too

Thanks for the tutorial. We will follow this guideline in the future.

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
### Summary
Rope fix

### Test plan
CI Passes

cc: @haowhsu-quic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants