Skip to content

Fix buck target for LLM runner util #14345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fix buck target for LLM runner util #14345

merged 2 commits into from
Sep 16, 2025

Conversation

kirklandsign
Copy link
Contributor

Summary

util.h needs constants.h and module.h

Test plan

CI

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14345

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 11 Pending

As of commit 3634467 with merge base a9e265f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kirklandsign kirklandsign marked this pull request as ready for review September 16, 2025 18:43
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

larryliu0820
larryliu0820 reviewed Sep 16, 2025
View reviewed changes
extension/llm/runner/targets.bzl
],
exported_deps = [
":constants",
"//executorch/extension/module:module" + aten_suffix,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does stats need module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this target name should be renamed to util

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in another PR

@Gasoonjia Gasoonjia merged commit 2f21092 into main Sep 16, 2025
125 checks passed
@Gasoonjia Gasoonjia deleted the fix-buck-llm-runner branch September 16, 2025 21:38
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@kirklandsign @StrycekSimon
Fix buck target for LLM runner util (pytorch#14345)
cad9f45 
### Summary
util.h needs constants.h and module.h

### Test plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 left review comments

@lucylq lucylq lucylq approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirklandsign @larryliu0820 @lucylq @Gasoonjia