Skip to content

Qualcomm AI Engine Direct - Rope Fix #14346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Qualcomm AI Engine Direct - Rope Fix #14346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/qualcomm/oss_scripts/llama/model/static_llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ def __init__(self, layer_idx: int, config: ModelArgs, output_new_cache_only=Fals
self.enable_masked_softmax = getattr(config, "enable_masked_softmax", False)
self.use_qk_norm = config.use_qk_norm
self.qk_norm_before_rope = config.qk_norm_before_rope
# If None, assume each layer uses rope
self.use_rope = (
config.no_rope_layer_interval
and (layer_idx + 1) % config.no_rope_layer_interval
config.no_rope_layer_interval is None
or (layer_idx + 1) % config.no_rope_layer_interval
)

if self.use_qk_norm:
Expand Down
Loading