Back out "Add extra logging in CoreML (#13890)" #14353
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14353
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 92f9a8c with merge base b1a41e7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581442. |
This PR needs a
|
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
metascroy
force-pushed
the
export-D82581442
branch
from
bc99fb3 to
b329ccd
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581442. |
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
metascroy
force-pushed
the
export-D82581442
branch
from
b329ccd to
92f9a8c
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581442. |
Differential Revision: D82581442 Pull Request resolved: pytorch#14353
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Cherry picking #14353The cherry pick PR is at #14568 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
4 participants
Summary:
Original commit changeset: ae667b071853
Original Phabricator Diff: D81256207
Differential Revision: D82581442