Skip to content

Conversation

DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Sep 16, 2025

Summary:
Migrate some custom cadence ops + some interface fixes and fixes in ref impl tests.

Reviewed By: mcremon-meta

Differential Revision: D82566217

Copy link

pytorch-bot bot commented Sep 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14357

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 7 Pending

As of commit 376ea19 with merge base 02b39bf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating diff in D82566217.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@DrJessop DrJessop changed the title Migrate uncommon cadence custom ops from Jarvis.nn.ref_implementations -> executorch ref_implementations Ref implementations interface fixes Sep 16, 2025
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating diff in D82566217.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Sep 17, 2025
Summary:

Migrated old ref impl to new ref impl, fixed some interface bugs caught in migration

Reviewed By: mcremon-meta

Differential Revision: D82566217
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating diff in D82566217.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Sep 17, 2025
Summary:

Migrated old ref impl to new ref impl, fixed some interface bugs caught in migration

Reviewed By: mcremon-meta

Differential Revision: D82566217
Summary:

Migrated old ref impl to new ref impl, fixed some interface bugs caught in migration

Reviewed By: mcremon-meta

Differential Revision: D82566217
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating diff in D82566217.

@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating diff in D82566217.

@facebook-github-bot facebook-github-bot merged commit ed179c0 into pytorch:main Sep 17, 2025
124 of 128 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82566217

Pull Request resolved: pytorch#14357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants