Skip to content

Conversation

ivayloen
Copy link
Contributor

Summary:
Applying the max kernel num setting through a config/mode results in both host and target builds to limit number of kernels. This can result in a case where the host tooling is building with all ops/kernels but has the setting applied causing crashes on load.

Host doen't (usually) have such memory limitation as target so adding select to disable the application of max kernel num when applying a host toolchain.

Differential Revision: D82579896

Copy link

pytorch-bot bot commented Sep 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 9f47d6d with merge base c9f46e2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
@facebook-github-bot
Copy link
Contributor

@ivayloen has exported this pull request. If you are a Meta employee, you can view the originating diff in D82579896.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ivayloen added a commit to ivayloen/executorch that referenced this pull request Sep 17, 2025
…ch#14365)

Summary:

Applying the max kernel num setting through a config/mode results in both host and target builds to limit number of kernels. This can result in a case where the host tooling is building with all ops/kernels but has the setting applied causing crashes on load. 

Host doen't  (usually) have such memory limitation as target so adding select to disable the application of max kernel num when applying a host toolchain.

Differential Revision: D82579896
@facebook-github-bot
Copy link
Contributor

@ivayloen has exported this pull request. If you are a Meta employee, you can view the originating diff in D82579896.

…ch#14365)

Summary:

Applying the max kernel num setting through a config/mode results in both host and target builds to limit number of kernels. This can result in a case where the host tooling is building with all ops/kernels but has the setting applied causing crashes on load. 

Host doen't  (usually) have such memory limitation as target so adding select to disable the application of max kernel num when applying a host toolchain.

Reviewed By: larryliu0820

Differential Revision: D82579896
@facebook-github-bot
Copy link
Contributor

@ivayloen has exported this pull request. If you are a Meta employee, you can view the originating diff in D82579896.

@facebook-github-bot facebook-github-bot merged commit d825fd4 into pytorch:main Sep 23, 2025
129 of 132 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82579896

Pull Request resolved: pytorch#14365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants