Arm backend: Remove sin_cos_support.py #14370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14370
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 883d780 with merge base bc18834 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
The operator_support check always approved sin and cos operators, which means they can be moved to the supported operator lists in tosa_profile_supported_op_lists.py. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: I2a3aea60a19dc9c6e95d6cf30c84d59a7c737850
Sebastian-Larsson
force-pushed
the
remove_sin_cos_support
branch
from
26d6ef3 to
883d780
Compare
digantdesai
approved these changes
Sep 17, 2025
|
File removed but it not present in the buck2 files |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
The operator_support check always approved sin and cos operators, which means they can be moved to the supported operator lists in tosa_profile_supported_op_lists.py. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator_support check always approved sin and cos operators, which means they can be moved to the supported operator lists in tosa_profile_supported_op_lists.py.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218